Addition of Gear_Selection Module #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fix for locality mismatch in drivers module
more AI drivers fixes
|
This commit is in response to the following issue (lines 224-236). |
|
This commit is in response to the following issue #135 |
BlackHawkPL
reviewed
Jan 19, 2018
| @@ -221,10 +221,23 @@ if (!isDedicated) then { | |||
| player setVariable ["FW_Spectating", true, true]; | |||
| [true] call acre_api_fnc_setSpectator; | |||
|
|
|||
| //If babel is enabled, allowed spectator to hear all languages present in mission. | |||
| if (!isNil "FW_enable_babel" && FW_enable_babel) then { | |||
There was a problem hiding this comment.
Add lazy evaluation (wrap FW_enable_babel in {}) to avoid game trying to retrieve value even if it's nil.
| @@ -221,10 +221,23 @@ if (!isDedicated) then { | |||
| player setVariable ["FW_Spectating", true, true]; | |||
| [true] call acre_api_fnc_setSpectator; | |||
|
|
|||
| //If babel is enabled, allowed spectator to hear all languages present in mission. | |||
| if (!isNil "FW_enable_babel" && FW_enable_babel) then { | |||
| _missionLanguages = []; | |||
| _codeText = format [_code, str _classname]; | ||
| diag_log text _codeText; | ||
| _call = compile _codeText; | ||
| call _call; |
There was a problem hiding this comment.
you can merge these 2 lines
|
@nathan423 Would you have any objections to me including this in my fork of the framework? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add the following:
A menu, accessible during the briefing stage of a multiplayer mission (also in single player and maybe local multiplayer), giving the player the ability to choose aspects of their gear, as defined by the mission maker. The file 'settings.hpp' includes all the config for the module, including category support, custom scripting options, and full customization support for the actual display of the options.
A help file is forthcoming.