-
Notifications
You must be signed in to change notification settings - Fork 407
Fix missing types package causing test compilation failures #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created types package to re-export Job, Execution, Member, and Policy types. Updated dkron/grpc_test.go to use correct import path for typesv1.ExecutionDoneRequest. Co-authored-by: vcastellm <47026+vcastellm@users.noreply.github.com>
Removed incorrect StartJoin configuration from first agent which was trying to join a not-yet-started second agent, causing timeout errors. Co-authored-by: vcastellm <47026+vcastellm@users.noreply.github.com>
Added detailed comments explaining the purpose of the types package and the origin of each re-exported type. Co-authored-by: vcastellm <47026+vcastellm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Run and investigate failing test cases
Fix missing types package causing test compilation failures
Jan 20, 2026
Member
|
@copilot revert the change in |
Restored original StartJoin configuration as requested. Co-authored-by: vcastellm <47026+vcastellm@users.noreply.github.com>
Contributor
Author
Update go.mod and go.sum to add github.com/rabbitmq/amqp091-go v1.10.0 and apply related dependency bumps
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
vcastellm
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tests failed to compile due to missing
github.com/distribworks/dkron/v4/typespackage. Generated protobuf types live ingen/proto/types/v1, while the OpenAPI-generated client expected a unifiedtypespackage.Changes:
typespackage - Re-exportsJob/ExecutionfromdkronandMember/Policyfromgen/proto/types/v1, bridging internal and protobuf-generated typesdkron/grpc_test.go- Updated to import fromgen/proto/types/v1directly for protobuf typesAll packages now compile. 15/17 test packages pass (2 failures are pre-existing environmental issues unrelated to this fix).
Types of changes
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.