-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added zk cryptography #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aritkulova
commented
Dec 9, 2024
•
edited
Loading
edited
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
switched all files to one pragma circom version
added spaces between operators; linting
ellipic -> elliptic ADDERS_NUMBER -> ADDRES_NUMBER
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
Arvolear
reviewed
Jan 3, 2025
mock is for tests now
SparseMerkleTreeVerifier -> SparseMerkleTree
Arvolear
reviewed
Jan 6, 2025
Arvolear
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Arvolear
added a commit
that referenced
this pull request
Jan 14, 2025
* Added zk cryptography (#14) * Add hash functions * Add zk cryptography * fix deps * fix test runner * linted and reorganised hash functions; switched all files to one pragma circom version * linted wasm-test * updated hardhat-zkit package version * linted zk cryptography circom files * cleaned up wasm-test js files * renamed functions to camel case * removed double spaces; added spaces between operators; linting * refactored comments, corrected typos * linting * updated dependencies * rewrote tests from wasm to hardhat: bigInt folder * rewrote tests from wasm to hardhat: bitify folder * rewrote tests from wasm to hardhat: hasher folder * rewrote tests from wasm to hardhat: int folder * transfered common functions to helperFunctions file * fixed typos: ellipic -> elliptic ADDERS_NUMBER -> ADDRES_NUMBER * allowed UnlimitedContractSize for verifiers contracts * updated hardhat-zkit version * rewrote tests from wasm to hardhat: matrix folder * fixed typos * switched to same order of inputs in sig folder * rewrote tests from wasm to hardhat: signature folder * rewrote tests from wasm to hardhat: ec folder * fixed typos * trying to fix compile in ci * trying to adjust ram in case its github limit * refactored possibly undefined vars in tests * checking a pipeline without 4 biggest circuits * fixed tests for brainloop: automatically generated verifier names were too long, so corresponding contracts were not generated; fixed by creating verifiers dirrectly whithin the tests * refactored assertion checks in tests * updated zkit hardhat version * let -> const in tests * deleted wasm-test folder * trying to fix ci * trying to fix ci command * disabled ci checks * consistency in tests * added missing BigSubNonEqual test * cleaned up * mock directory renamed to main; mock is for tests now * moved mgf1.circom to utils * fixed typo in Pippenger * fixed paths (renamed mock to main) * switched to local circuits instead of circomlib's * renamed utils to mask * CommitmentVerifier -> Commitment SparseMerkleTreeVerifier -> SparseMerkleTree * updated dependencies * updated tests * fixed package-lock * linting * removed unnecessary dependencies * returned chai deps --------- Co-authored-by: 1KitCat1 <denischool119@gmail.com> Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com> * update readme * update readme --------- Co-authored-by: Yuliia Aritkulova <94910987+aritkulova@users.noreply.github.com> Co-authored-by: 1KitCat1 <denischool119@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.