Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 24075 - Can't use toChars with ushort or ubyte #8866

Merged
merged 4 commits into from
Dec 30, 2023

Conversation

eoan-ermine
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 20, 2023

Thanks for your pull request and interest in making D better, @eoan-ermine! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24075 enhancement Can't use toChars with `ushort` or `ubyte`

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8866"

@eoan-ermine eoan-ermine changed the title Fix Issue 24075 - Can't use toChars with ushort or ubyte Fix issue 24075 - Can't use toChars with ushort or ubyte Dec 20, 2023
std/conv.d Outdated Show resolved Hide resolved
Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish it would just promote the integer instead of instantiating a new Result struct for each integral type, but that's an enhancement for a future PR

std/conv.d Outdated Show resolved Hide resolved
@dkorpel dkorpel merged commit 713ac80 into dlang:master Dec 30, 2023
11 checks passed
@eoan-ermine eoan-ermine deleted the issue#24075 branch December 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants