Skip to content

CVE-2013-0350: Drop tcp_smtp log #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bgermann wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CVE-2013-0350: Drop tcp_smtp log #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tcp_smtp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,8 @@ smtp_line(f, line)
struct smtp_state *state;
const char *s;
int addr_changed = 0;
FILE*log;

state = (struct smtp_state *)f->udata;

if ((log = fopen("/tmp/smtp.log", "a")))
fprintf(log, "smpt_line [%s]\n", line);

if (state->in_data) {
if (strcmp(line, ".") == 0) {
state->in_data = 0;
Expand All @@ -180,18 +175,15 @@ if ((log = fopen("/tmp/smtp.log", "a")))
} else {
/* Normalize the command line */
normalize_line(line);
if (log)fprintf(log, "normalized to [%s]\n", line);
if ((s = strip_prefix(line, "MAIL FROM:"))) {
snprintf(state->from_addr, sizeof state->from_addr, "%s", s);
normalize_addr(state->from_addr);
addr_changed = 1;
if (log)fprintf(log, "from_addr = [%s]\n", state->from_addr);
}
else if ((s = strip_prefix(line, "RCPT TO:"))) {
snprintf(state->to_addr, sizeof state->to_addr, "%s", s);
normalize_addr(state->to_addr);
addr_changed = 1;
if (log)fprintf(log, "to_addr = [%s]\n", state->to_addr);
}
else if (strcmp(line, "DATA") == 0) {
state->in_data = 1;
Expand All @@ -213,10 +205,8 @@ if (log)fprintf(log, "to_addr = [%s]\n", state->to_addr);
if (strcmp(line, "QUIT") != 0)
snprintf(f->desc, sizeof f->desc, "%s", line);
}
if (log)fprintf(log, "set desc to: [%s]\n", f->desc);
}

if (log)fclose(log);
}

/*
Expand Down