Prevent overflow of matrix interation values #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maintainer.
When creating a matrix, if the maxLinesPerFile exceeds 65535, the matrix size is determined by the overflowed value.
This can cause a segmentation fault when initializing the matrix using fill.
Also, when comparing two files, if the product of the number of lines in both files exceeds 4294967295, there is a possibility to access the index using the overflowed value.
I suggest changing the variable type that can be used as the matrix index from unsigned to size_t.
Thanks.