Service owc #102
Merged
Service owc #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raster and vector
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
| return this.createLayerFromOffering(offering, resource, owc, targetProjection); | ||
| const offerings = resource.properties?.offerings; | ||
| if (offerings) { | ||
| // TODO: allow Multiple offerings ??? |
There was a problem hiding this comment.
Currently we only support to use one Offering, so we do not create multiple Layers e.g. if there is a Resource with WMS and WFS offering.
Then we go in the order like: isWmsOffering | isWmtsOffering | isWfsOffering | isTMSOffering | offerings[0]
I think this should be extended later on to support multiple layers, e.g. a WMS and a WMTS.
boeckMt
commented
Dec 2, 2021
boeckMt
commented
Dec 2, 2021
| @@ -700,35 +1089,39 @@ export class OwcJsonService { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * TODO: add more vendor params ?? | |||
There was a problem hiding this comment.
Here it was requested to add more vendor params e.g. like cql_filter so the data can be filtered by configuration.
See ukis-frontend/project-zki-viewer/-/issues/93
There was a problem hiding this comment.
+1 for this quest. Currently i put those directly in the request URL...
voinSR
reviewed
Dec 3, 2021
* Update Layers.ts typo fix pupupFunktion --> pupupFunction (could be a breaking change in come apps) * update of map-ol.service.ts rename pupupFunktion to pupupFunction * Update CHANGELOG.md Renamed layer property pupupFunktion to pupupFunction * Update CHANGELOG.md * Update route-map.component.ts changed pupupFunktion to pupupFunction * Update map-ol.service.ts fixed typo pupupFunction to popupFunction * Update map-ol.service.ts fixed several typos pupup to popup * Update map-ol.service.spec.ts changed pupupFunktion to popupFunction * Update Layers.ts fixed type pupup to popup * Update route-map.component.ts fixed type pupup to popup * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
GlobalProgressComponent.Issue Number: N/A
What is the new behavior?
closes Allow hidden/merged layers in LayerGroup/Layer #99
closes Use properties from OWS Context GeoJSON Standard #97
closes Remove owc-control #77
@dlr-eoc/core-ui: Missing output was added.
@dlr-eoc/layer-control: Legend images get shown in a new tab on click and resized if the are to large
@dlr-eoc/map-ol: Implemented new layers TMS, KML and fix GeoJSON from url.
@dlr-eoc/services-ogc: Implemented new layers TMS Raster and Vector, KML, XYZ, fix some OWC Parsing and better support for OWC writing
Does this PR introduce a breaking change?
BREAKING CHANGES
and see https://github.com/dlr-eoc/ukis-frontend-libraries/pull/102/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Other information
Is it part of one/more packages and which?