-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly prepend ProvisioningTemplate class with helper #28
Conversation
fixes https://community.theforeman.org/t/unable-to-open-foreman-settings-error-displayed/38001 Want to have a look @evgeni? |
This looks like Ruby. I never understood how Ruby's ClassMethods and prepend and include and everything works. #yolo? |
It's at least tested locally and it works. I needed a few tries myself. Prepending class methods is just magic... |
I'll also add a test for that later before merging.. |
Can you see if #29 also solves it? |
81c39ca
to
350d757
Compare
Your solution also worked. I simplified it even more and added a test for it. This now looks like a good solution to me. |
350d757
to
c45e253
Compare
fixes error during settings rendering because method is not found
c45e253
to
bcdf635
Compare
Interesting. I thought |
I'll go with this PR as we use the same here in git_templates: https://github.com/dm-drogeriemarkt/foreman_git_templates/blob/master/lib/foreman_git_templates/engine.rb#L34 Tests are passing and fix is verified locally - merging... |
No description provided.