Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the Extra movement conditions #211
feat: Added the Extra movement conditions #211
Changes from all commits
7960ba6
1365964
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Potential bug in getDestination condition check.
In the else branch, the condition is once again checking 'target' rather than the newly assigned 'other'. This appears to be a copy-paste mistake and may lead to incorrect behavior when hero.getTargetAs(Ship.class) is null but hero.getTarget() returns a valid entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Typo in property naming: movementCondtion1.
The field name 'movementCondtion1' appears to contain a typo. Standardizing the naming to 'movementCondition1' (and similarly for condition 2-5) would improve readability and reduce potential confusion in the future.
Suggested implementation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (review_instructions): Typo in variable name 'movementCondtion1' affecting code clarity.
Renaming 'movementCondtion1' to 'movementCondition1' (and similarly for the subsequent fields) would improve readability and maintainability.
Review instructions:
Path patterns:
*.java
Instructions:
It is a plugin for the darkbot bot in java, check that the code is clean and efficient.