-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New project structure #38
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Also added the logos as in the repository. |
@dmotts @swarupn17 @shawaiz-khan @Brijeshthummar02 @team What do you think about these changes? |
@HomerusJa Tremendous work 👏! I'll merge your work and we'll try to get a demo up as soon as possible. |
@HomerusJa could you add '.idea' to the .gitignore file? I don't feel comfortable merging, just incase there's an API key somewhere exposed in the code. Thank you for understanding!🙂 |
I can do that, however, the .idea folder only contains IDE-specific settings and there is no risk at all of submitting API keys. If you dont want to have any IDE settings in this repository, we should communicate that clearly. |
Ima create issues for the different tasks mentioned above. |
@HomerusJa that would be easy to assist. |
Can you start from the bottom? |
This pull request contains the project structure needed for the new architecture discussed in #31
General Changes
Frontend Changes
I didnt touch the frontend as this is not my area of expertise.
Backend Changes
Switch to uv as a package manager
I switched from Poetry to uv as a package manager, as it is the current best solution. Following a comparison between uv and poetry:
Benefits of uv
Drawbacks of uv
Benefits of Poetry
Drawbacks of Poetry
Add Ruff for linting
I added Ruff and some basic ruff config as a python linter as it is the commonly agreed best linter currently available. Some reasons on why to use Ruff:
pyproject.toml
.Github Action Changes
autocomment-on-events.yml
to clean up the action directoryTodos
I think those can be put in different issues and handled seperately. This list is not comprehensive.