Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null values #90

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Null values #90

merged 5 commits into from
Feb 4, 2020

Conversation

skhilton
Copy link
Collaborator

This pull requests handles null values in the data. There are three main changes to the data to handle null values

  1. data cleaning
    During the data cleaning step, metric values which are undefined, null, NaN, false, or "" are all cast to undefined.

  2. circles disappear
    If the metric value is undefined, the circle radius is set to zero.

  3. The protein structure turns grey.
    If the metric value is undefined, the point remains highlighted on the protein structure but turns grey to signal missing data. We could also consider removing it from the protein structure all together.

The idea behind these changes is that we don't actually remove the point so it is still classed as selected. When you change to another metric, the point reappears with the correct color.

I don't believe that any changes need to be made to handle null values for the logoplots but if you could check that @huddlej that would be great!

An improvement we could make in the future is to have a metric option disappear from the dropdown menu if none of the sites have valid values for the metric. This is described in issue #70.

Closes issue #69

@skhilton skhilton requested a review from huddlej January 28, 2020 19:16
@skhilton
Copy link
Collaborator Author

whoops, @huddlej, forgot to mention. I have included a test data set in _data/test.csv. There are no valid values for VIDD5 mindiffsel. This file should probably be deleted before the changes are merged.

Filters data with undefined metric values to prevent d3 from drawing a SVG path
with "NaN" values.
Copy link
Collaborator

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! There was a minor issue where the context view tried to draw a path with "NaN" values and I've added a commit to address that.

The test data were very helpful. I think we should keep these somewhere in the repo, if not in the top-level docs directory, for future testing.

@skhilton skhilton merged commit 6bd4cd4 into master Feb 4, 2020
@skhilton skhilton deleted the null_values branch February 4, 2020 19:11
@skhilton skhilton mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants