Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests handles null values in the data. There are three main changes to the data to handle null values
data cleaning
During the data cleaning step, metric values which are undefined, null, NaN, false, or "" are all cast to undefined.
circles disappear
If the metric value is undefined, the circle radius is set to zero.
The protein structure turns grey.
If the metric value is undefined, the point remains highlighted on the protein structure but turns grey to signal missing data. We could also consider removing it from the protein structure all together.
The idea behind these changes is that we don't actually remove the point so it is still classed as selected. When you change to another metric, the point reappears with the correct color.
I don't believe that any changes need to be made to handle null values for the logoplots but if you could check that @huddlej that would be great!
An improvement we could make in the future is to have a metric option disappear from the dropdown menu if none of the sites have valid values for the metric. This is described in issue #70.
Closes issue #69