refactor: better state management #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/fff/state.lua
Outdated
| M = { | ||
| initialized = false, | ||
| last_scan_time = 0, | ||
| config = { |
Owner
There was a problem hiding this comment.
can we have the default config isolted somewhere so it is easy to link this from the readme
Author
There was a problem hiding this comment.
Moved the default config into its own variable in the file.
dmtrKovalenko
approved these changes
Aug 13, 2025
Owner
dmtrKovalenko
left a comment
dmtrKovalenko
left a comment
There was a problem hiding this comment.
Thanks for doing this. This is huge, I was always delaying writing the type defs for all the state and configuration
shawnyu5
force-pushed
the
refactor/state_management
branch
from
5689ef1 to
7e4ac6a
Compare
Author
|
Merged main into this branch. Fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to standardise state management by refactor state management into its own module, and add type hints for the state table. This makes it easier to add additional fields to the state later on.
Also fixed a few places where the user config is not being respected.