-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate state transition validation from nonState transition valdations #12120
Open
todor-ivanov
wants to merge
7
commits into
dmwm:master
Choose a base branch
from
todor-ivanov:feature_SeteWhitelist_SupportChangeInReqmgr2_fix-12307
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Separate state transition validation from nonState transition valdations #12120
todor-ivanov
wants to merge
7
commits into
dmwm:master
from
todor-ivanov:feature_SeteWhitelist_SupportChangeInReqmgr2_fix-12307
Commits on Oct 17, 2024
-
Add SiteList actions to transient statuses in ReqMgr2
Add proper checks for allowed request properties changes && Stop reducing request_args only to RequestPriority for noStatusTransition actions Extend allowed arguments including stat_keys and RequestStatus && Call the relevant modifiers from _handleNoStatusUpdate Fix missing RequestName from request_args on mutipple calls of validate_request_update_args Add proper log messages for Sitelists changes Remove redundant validation calls && Update reqdb couch with single action && Move reduceReport to Utils. Typo Remove forgotten commented lines of code Review comments Source files pylint fixes Review comments
Configuration menu - View commit details
-
Copy full SHA for eee7300 - Browse repository at this point
Copy the full SHA eee7300View commit details -
Unit tests Unit tests pylint fixes Unit tests - remove tests for reduceReport
Configuration menu - View commit details
-
Copy full SHA for 48fe7bd - Browse repository at this point
Copy the full SHA 48fe7bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd71135 - Browse repository at this point
Copy the full SHA cd71135View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfbef4f - Browse repository at this point
Copy the full SHA cfbef4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a5d1f7 - Browse repository at this point
Copy the full SHA 7a5d1f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dee132a - Browse repository at this point
Copy the full SHA dee132aView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62a6d43 - Browse repository at this point
Copy the full SHA 62a6d43View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.