Skip to content

Commit

Permalink
[DEVEX-2463] dx-app-wizard should generate template with AEE 24.04 by…
Browse files Browse the repository at this point in the history
… default (#1445)

* update default release value to 24.04

* update tests

* update changelog
  • Loading branch information
jsitarova-dnanexus authored Feb 26, 2025
1 parent 6af24b3 commit ed99b73
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

## Unreleased

### Changed

* dx-app-wizard generates template with AEE 24.04 by default

## [391.0] - beta

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/python/dxpy/scripts/dx_app_wizard.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ def main(**kwargs):
######################

app_json['runSpec']['distribution'] = 'Ubuntu'
app_json['runSpec']['release'] = '20.04'
app_json['runSpec']['release'] = '24.04'
app_json['runSpec']['version'] = "0"

#################
Expand Down
2 changes: 1 addition & 1 deletion src/python/test/test_dx_app_wizard.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_dx_app_wizard(self):
self.assertEqual(dxapp_json['regionalOptions']['aws:us-east-1']['systemRequirements']['*']['instanceType'],
InstanceTypesCompleter.default_instance_type.Name)
self.assertEqual(dxapp_json['runSpec']['distribution'], 'Ubuntu')
self.assertEqual(dxapp_json['runSpec']['release'], '20.04')
self.assertEqual(dxapp_json['runSpec']['release'], '24.04')
self.assertEqual(dxapp_json['runSpec']['version'], '0')
self.assertEqual(dxapp_json['runSpec']['interpreter'], 'python3')
self.assertEqual(dxapp_json['runSpec']['timeoutPolicy']['*']['hours'], 24)
Expand Down

0 comments on commit ed99b73

Please sign in to comment.