Skip to content

fix: corrects example usage of accessibility prop with custom announcements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thawkin3
Copy link

In this example page for writing your own custom screen reader announcements, the docs are missing a set of curly braces. The specification for the accessibility prop is that it is an object which can have an announcements key. That would require you to write code like this:

accessibility={{
  announcements,
}}

Instead, the docs show only one set of curly braces, indicating that the accessibility prop is just an object with properties like onDragStart, onDragMove, onDragOver, onDragEnd, and onDragCancel, which is incorrect.

accessibility={
  announcements,
}

Hope this helps!

@thawkin3
Copy link
Author

Looks like this PR already had me beat: #14. This contains the same fix. If we could merge his earlier PR, that'd be great!

@thawkin3 thawkin3 closed this Oct 25, 2022
@thawkin3 thawkin3 deleted the patch-1 branch October 25, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant