Feat: 나의 기록 조회 V2 작업(퍼센테이지 값 추가) #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MyProfileResponseV1를 추가 - 응답 형식 확인 테스트 코드는 컨트롤러 테스트에 추가 예정
WonSteps
approved these changes
Nov 6, 2024
| @@ -1,17 +1,12 @@ | |||
| package com.dnd.runus.presentation.v1.member.dto.response; | |||
There was a problem hiding this comment.
나중에 service 계층에서는 presentation에 의존하지 않도록 따로 수정하면 좋을 것 같아요!
There was a problem hiding this comment.
#301 이슈에서 해당 작업을 진행합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
/api/v2/members/profiles💡 반영할 내용 및 변경 사항 요약
MyProfileResponse의 필드 값을 변경합니다.getMyProfile메서드가MyProfileResponse를 리턴하도록 합니다.MyProfileResponse을MyProfileResponseV1으로 변경합니다.MyProfileResponseV1에서MyProfileResponse값을 변환할 수 있게 합니다.MyProfileResponseV2를 생성하고/api/v2/members/profilesapi를 추가합니다.🔍 리뷰 요청/참고 사항