Fix: 러닝 경로가 빈 리스트일 경우 좌표를 0,0,0인 지점을 저장하게 수정 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaewon-pro
approved these changes
Dec 29, 2024
| public RunningRecordMetrics{ | ||
| //러닝 경로 유요성 확인, 기본으로 null Point 좌표가 들어가게 | ||
| if (route == null || route.isEmpty()) { | ||
| Point nullIsLandPoint = new Point(0, 0); |
There was a problem hiding this comment.
제안
nullIsLandPoint변수가 0, 0 좌표를 담고 있어서,
null이란 네이밍보다는 empty나 missing 등으로 바꾸면 좋을 것도 같아요!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
💡 반영할 내용 및 변경 사항 요약
🔍 리뷰 요청/참고 사항