Add test for non-default paths for cli, fix issues in reading of files related to that. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s related to that
tomarnepedersen
approved these changes
Apr 24, 2025
Collaborator
tomarnepedersen
left a comment
tomarnepedersen
left a comment
There was a problem hiding this comment.
Checked and working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52
One way to test this, is to use this branch and run pytest, and then check against having the old code in read_files.py (see commit changes).
Another way to test is to use the main branch and this branch, and try the same command for reading the situation and target ship files from somewhere else on the system, and it will bomb on main (see issue description).