fix: wrong slide direction animation on page changes (#36)

docchula · Feb 1, 2025 · f4aad5d · f4aad5d
1 parent 1488fe8
commit f4aad5d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 34 deletions.
diff --git a/src/app/home/course/course.page.html b/src/app/home/course/course.page.html
@@ -1,9 +1,7 @@
 <link rel="stylesheet" href="course.page.scss">
 <ion-header>
     <ion-toolbar>
-        <ion-buttons slot="start" [routerLink]="'/home/'+year">
-            <ion-back-button [defaultHref]="'/home/'+year"></ion-back-button>
-        </ion-buttons>
+        <ion-back-button slot="start" [defaultHref]="'/home/'+year"></ion-back-button>
         <ion-title>
             {{ course ?? 'Course' }}
             @if (courseProgress.duration > 0) {

diff --git a/src/app/home/course/course.page.ts b/src/app/home/course/course.page.ts
@@ -1,6 +1,6 @@
 import {AfterViewInit, Component, ElementRef, OnDestroy, OnInit, ViewChild} from '@angular/core';
 import {combineLatest, EMPTY, Observable, startWith, Subject} from 'rxjs';
-import {ActivatedRoute, Router, RouterLink} from '@angular/router';
+import {ActivatedRoute, Router} from '@angular/router';
 import {CourseMembers, Lecture, ManService} from '../../man.service';
 import {first, map, switchMap} from 'rxjs/operators';
 import videojs from 'video.js';
@@ -46,8 +46,6 @@ import {AsyncPipe, DatePipe, DecimalPipe, NgClass} from '@angular/common';
     imports: [
         IonHeader,
         IonToolbar,
-        IonButtons,
-        RouterLink,
         IonBackButton,
         IonTitle,
         IonContent,

diff --git a/src/app/home/home.module.ts b/src/app/home/home.module.ts
@@ -16,6 +16,7 @@ import { IonHeader, IonToolbar, IonTitle, IonButtons, IonButton, IonIcon, IonCon
         IonHeader,
         IonToolbar,
         IonTitle,
+        IonText,
         IonButtons,
         IonButton,
         IonIcon,
@@ -26,36 +27,17 @@ import { IonHeader, IonToolbar, IonTitle, IonButtons, IonButton, IonIcon, IonCon
         IonCard,
         IonCardHeader,
         IonCardTitle,
-        IonHeader,
-        IonToolbar,
-        IonButtons,
-        IonBackButton,
-        IonTitle,
-        IonContent,
-        IonGrid,
-        IonRow,
-        IonCol,
-        IonText,
-        IonCard,
-        IonCardHeader,
-        IonCardTitle,
         IonCardContent,
         IonList,
         IonListHeader,
         IonLabel,
         IonItem,
-        IonIcon,
         IonProgressBar,
-        IonHeader,
-        IonToolbar,
-        IonButtons,
         IonBackButton,
-        IonTitle,
-        IonContent,
-        IonList,
-        IonItem,
-        IonLabel,
-        HomePage, ListPage, CoursePage
+        HomePage, 
+        ListPage, 
+        CoursePage
     ]
 })
+
 export class HomePageModule { }
diff --git a/src/app/home/list/list.page.html b/src/app/home/list/list.page.html
@@ -1,8 +1,6 @@
 <ion-header>
   <ion-toolbar>
-    <ion-buttons slot="start" routerLink="/home">
-      <ion-back-button defaultHref="/home"></ion-back-button>
-    </ion-buttons>
+    <ion-back-button slot="start" defaultHref="/home"></ion-back-button>
     <ion-title>
       <span [ngStyle]="{'background-color': colorByFolderName(year)}">{{ year || 'Loading'}}</span>
     </ion-title>

diff --git a/src/app/home/list/list.page.ts b/src/app/home/list/list.page.ts
@@ -4,14 +4,14 @@ import { EMPTY, Observable } from 'rxjs';
 import { map, switchMap } from 'rxjs/operators';
 import { ManService } from '../../man.service';
 import { colorByFolderName } from '../../../helpers';
-import { IonHeader, IonToolbar, IonButtons, IonBackButton, IonTitle, IonContent, IonList, IonItem, IonLabel } from '@ionic/angular/standalone';
+import { IonHeader, IonToolbar, IonBackButton, IonTitle, IonContent, IonList, IonItem, IonLabel } from '@ionic/angular/standalone';
 import { NgStyle, AsyncPipe } from '@angular/common';
 
 @Component({
     selector: 'app-list',
     templateUrl: './list.page.html',
     styleUrls: ['./list.page.scss'],
-    imports: [IonHeader, IonToolbar, IonButtons, RouterLink, IonBackButton, IonTitle, NgStyle, IonContent, IonList, IonItem, IonLabel, AsyncPipe]
+    imports: [IonHeader, IonToolbar, RouterLink, IonBackButton, IonTitle, NgStyle, IonContent, IonList, IonItem, IonLabel, AsyncPipe]
 })
 export class ListPage implements OnInit {
     year: string;