Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Commit

Permalink
Merge pull request #953 from docker/windows_e2e_docker_logout
Browse files Browse the repository at this point in the history
On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests
  • Loading branch information
gtardif authored Nov 23, 2020
2 parents e984f76 + 1f8fbe5 commit 97560f8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/optional-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,7 @@ jobs:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
run: make e2e-aci
# need to docker logout on windows nodes, it seems GHActions does a `docker login --user githubactions` specifically on windows nodes
run: |
docker logout
make e2e-aci

0 comments on commit 97560f8

Please sign in to comment.