Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add Stop Grace Period to compatibility file. #2141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/ecs-compose-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ __Legend:__
| service.hostname | x |
| service.image | ✓ | Private images will be accessible by passing x-aws-pull_policy with ARN of a username+password secret
| service.isolation | x |
| service.labels | x |
| service.labels | |
| service.links | x |
| service.logging | ✓ | Can be used to customize CloudWatch Logs configuration
| service.network_mode | x |
Expand All @@ -64,7 +64,7 @@ __Legend:__
| service.ports | ✓ | Only symetrical port mapping is supported in ECS. See [Exposing ports](#exposing-ports).
| service.secrets | ✓ | See [Secrets](#secrets).
| service.security_opt | x |
| service.stop_grace_period | x |
| service.stop_grace_period | |
| service.stop_signal | x |
| service.sysctls | x |
| service.ulimits | ✓ | Only support `nofile` ulimit due to Fargate limitations
Expand Down
1 change: 1 addition & 0 deletions ecs/compatibility.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ var compatibleComposeAttributes = []string{
"services.secrets",
"services.secrets.source",
"services.secrets.target",
"services.stop_grace_period",
"services.user",
"services.volumes",
"services.volumes.read_only",
Expand Down