This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Limit EFS volume creation to public subnets #2231
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with EFS volumes when you have a lot of subnets - they can't be created. Actually by now it can only work if you have a network with only 3 public subnets in the 3 AWS availability zones without any additional subnets.
fixes #2164 , helps #1739
This helps by identifying the public subnets, and creates mount targets only for them, it expects the following:
Since there is no proper way of setting the subnets used by the volumes, I am proposing this so at least it tries to create the EFS mounts properly when you have a lot of subnets.