Temporarily disable SBOMs on GHA #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're chasing an issue with GHA and our SBOM indexer that's leading to *empty* SBOMs being published, which isn't great. For now, let's disable SBOMs for all our GHA architectures until we figure it out.
tianon
commented
Sep 24, 2024
| [ | ||
| first(.[] | select(normalized_builder == "buildkit")), | ||
| first(.[] | select(normalized_builder == "classic")), | ||
| first(.[] | select(normalized_builder == "oci-import")), | ||
| first(.[] | select(normalized_builder == "oci-import" and build_should_sbom)), # TODO remove this |
There was a problem hiding this comment.
This both validates that my conditional is correct and keeps the example of our oci-import SBOM code in the validated test output.
yosifkit
approved these changes
Sep 24, 2024
|
Cross-linking the update: docker-library/official-images#17629 🥳 (so we'll revert this soon) |
|
... and reverted in #83, closing the loop 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're chasing an issue with GHA and our SBOM indexer that's leading to empty SBOMs being published, which isn't great. For now, let's disable SBOMs for all our GHA architectures until we figure it out / fix it.