-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add history trace command #2904
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
a197f0b
to
78f22de
Compare
78f22de
to
d8a5cf8
Compare
Added support for viewing traces using Jaeger UI.
I think the UX is pretty ok and better than manual uploads and running The old otelutil conversion code may need some updates as well. Looks like some info, like process data, could be deduplicated. I quickly looked at |
d8a5cf8
to
7f84270
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
7f84270
to
3fd4ec0
Compare
Includes wip trace command on top of #2891
The goal was for this command to show a trace of the build directly, for example, in Jaeger UI, but it looks like there isn't a simple API that would allow uploading a trace to an existing Jaeger image (their upload feature is an ephemeral client-side-only solution).
Options would be to upload the trace spans again via controller APIs or build our own UI-only image that we could pair with a simple server that can return the trace JSON. Separating from #2891 in order to not block that PR.
The Jaeger conversion is mostly reuse of some old code. Looks like there is also a
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger
package now that probably has similar functionality.