docker-container: check error from response body when pulling image #2988
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
reviewed
Feb 12, 2025
driver/docker-container/driver.go
Outdated
| _, err = io.Copy(io.Discard, rc) | ||
| return err | ||
| defer resp.Close() | ||
| return jsonmessage.DisplayJSONMessagesToStream(resp, streams.NewOut(io.Discard), nil) |
There was a problem hiding this comment.
We can avoid the cli dependency:
Suggested change
| return jsonmessage.DisplayJSONMessagesToStream(resp, streams.NewOut(io.Discard), nil) | |
| return jsonmessage.DisplayJSONMessagesStream(resp, io.Discard, 0, false, nil) |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
ctn-driver-display-pull-error
branch
from
4f4757c to
3f82aad
Compare
tonistiigi
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes moby/moby#49453
On
ImageCreatewe should check if the pull response body has an error.