Draft
Conversation
Contributor
Author
|
/describe |
|
✅ PR description has been generated and updated! |
Signed-off-by: Derek Misler <derek.misler@docker.com>
33db075 to
bcfe3af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GitHub Checks API integration to all three CI workflows so that manually triggered reviews and PR description generation are surfaced as proper check runs on the PR's commit. Previously, these workflows ran silently without any visible check status on the PR; now they create a check run at the start and update it to
success,failure, orcancelledupon completion.Changes
.github/workflows/pr-describe.yml: Addedchecks: writepermission, aCreate check runstep at job start (namedGenerate PR Description), and anUpdate check runstep (runsalways()) to finalize the check status..github/workflows/review-pr.yml: Same pattern — addedchecks: write, creates aPR Reviewcheck run using the resolvedpr-numberinput orissue.number, and updates it on completion..github/workflows/self-review-pr.yml: Same pattern asreview-pr.yml— addschecks: write, creates and finalizes aPR Reviewcheck run tied to the PR'shead_sha.How to Test
workflow_dispatch); aPR RevieworGenerate PR Descriptioncheck should appear on the PR's Checks tab showingin_progressand then resolve tosuccessorfailure.cancelledrather than hanging asin_progress.