-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken links in CONTRIBUTING.md #5417
Conversation
Signed-off-by: Dilep Dev <34891655+DilepDev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5417 +/- ##
=======================================
Coverage 59.73% 59.73%
=======================================
Files 345 345
Lines 23394 23394
=======================================
Hits 13974 13974
Misses 8450 8450
Partials 970 970 |
Similar to #5041 |
Thank you @laurazard, @thaJeztah for the inputs, what would you suggest next step to be, is it to create the missing documentation in |
@DilepDev This PR is still an improvement overall, so I definitely think we should still merge it, and we can think about moving/maybe bringing back some of those old docs into moby/moby or here later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
In CONTRIBUTING.md updated "the review process we use for simple changes", "our style guide" and "building the documentation" with working links.
- How I did it
Used google and docs.docker for information
- How to verify it
NA
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
"closes #5416 "