Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links in CONTRIBUTING.md #5417

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

DilepDev
Copy link
Contributor

@DilepDev DilepDev commented Sep 8, 2024

- What I did
In CONTRIBUTING.md updated "the review process we use for simple changes", "our style guide" and "building the documentation" with working links.

- How I did it
Used google and docs.docker for information

- How to verify it
NA

- Description for the changelog

In CONTRIBUTING.md "the review process we use for simple changes", "our style guide" and "building the documentation" will point to the correct working links

- A picture of a cute animal (not mandatory but encouraged)

tiger

"closes #5416 "

Signed-off-by: Dilep Dev <34891655+DilepDev@users.noreply.github.com>
@laurazard laurazard self-assigned this Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (6b74160) to head (45d5596).
Report is 112 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5417   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         345      345           
  Lines       23394    23394           
=======================================
  Hits        13974    13974           
  Misses       8450     8450           
  Partials      970      970           

@Benehiko
Copy link
Member

Benehiko commented Sep 9, 2024

Similar to #5041

@DilepDev
Copy link
Contributor Author

Thank you @laurazard, @thaJeztah for the inputs, what would you suggest next step to be, is it to create the missing documentation in docker/cli referencing moby/docs and links from the waybackmachine ?

@laurazard
Copy link
Member

@DilepDev This PR is still an improvement overall, so I definitely think we should still merge it, and we can think about moving/maybe bringing back some of those old docs into moby/moby or here later.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 305985c into docker:master Oct 8, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Links in Contributing.md
5 participants