Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/docker/docker 164cae56ed95 (master, v-next) #5428

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

thaJeztah
Copy link
Member

full diff: moby/moby@2269acc...164cae5

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

oh! we need the changes from #5331 as well I think 🤦

@thaJeztah thaJeztah force-pushed the bump_docker_28 branch 2 times, most recently from 6041833 to 4ef0766 Compare September 24, 2024 13:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (ff853c4) to head (b12ac89).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5428   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files         345      345           
  Lines       23431    23432    +1     
=======================================
+ Hits        13999    14000    +1     
  Misses       8458     8458           
  Partials      974      974           

@thaJeztah thaJeztah force-pushed the bump_docker_28 branch 7 times, most recently from b22822e to b1c5ab4 Compare September 24, 2024 14:26
@laurazard
Copy link
Member

@thaJeztah while we're at it should we use a more recent commit?

@thaJeztah
Copy link
Member Author

@laurazard I was considering, but thought to first do this update, which gives all that's needed for #5331 😅

full diff: moby/moby@2269acc...164cae5

Co-authored-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ok! This one's green now.

I'll rebase #5331 once this is in. After that I'll have a look if current master brings more changes to address 🙈

@laurazard laurazard merged commit 3a3fe84 into docker:master Sep 24, 2024
89 checks passed
@thaJeztah thaJeztah deleted the bump_docker_28 branch September 24, 2024 14:53
@thaJeztah
Copy link
Member Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants