remove dockerd man-page (moved back to moby repository) #5773
+0
−515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When splitting the docker CLI from the moby/moby repository, the dockerd documentation and man-pages were moved to the CLI repository. This was a bit of a bad choice, as now the documentation and code lived in separate repositories, but when the CLI and dockerd packages were split, the man page for dockerd ended up in the CLI package. Starting with [moby@d6e9b5f], the dockerd man-page has been reintegrated into the moby repository, so we cab remove it from the CLI repository. [moby@d6e9b5f]: moby/moby@d6e9b5f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
kind/docs
status/2-code-review
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5773 +/- ##
=======================================
Coverage 59.42% 59.42%
=======================================
Files 347 347
Lines 29402 29402
=======================================
Hits 17472 17472
Misses 10958 10958
Partials 972 972 |
dvdksn
approved these changes
Jan 27, 2025
|
Don't merge yet; need to look at the right approach for this; merging this PR should make that error go away, but the same may still happen if someone happened to mix versions, so perhaps we need additional metadata on the package to indicate "docker-ce's dockerd man-page replaces the one in docker-ce-cli"; |
|
OK; other PR is fixed after adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
When splitting the docker CLI from the moby/moby repository, the dockerd documentation and man-pages were moved to the CLI repository. This was a bit of a bad choice, as now the documentation and code lived in separate repositories, but when the CLI and dockerd packages were split, the man page for dockerd ended up in the CLI package.
Starting with moby@d6e9b5f, the dockerd man-page has been reintegrated into the moby repository, so we cab remove it from the CLI repository.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)