completion: remove generic "os-only" for platforms#6010
Merged
vvoland merged 1 commit intodocker:masterfrom Apr 16, 2025
Merged
completion: remove generic "os-only" for platforms#6010vvoland merged 1 commit intodocker:masterfrom
vvoland merged 1 commit intodocker:masterfrom
Conversation
Using `--platform=linux` or `--platform=windows` is not commonly used (or recommended). Let's remove these from the list of suggested platforms. We should tweak this completion further, and sort the list based on the daemon's platform (putting linux first for a Linux daemon, and windows first on a Windows daemon), possibly with the correct architecture (and os-version) included, but we don't yet provide that information in `/_ping`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6010 +/- ##
=======================================
Coverage 58.88% 58.88%
=======================================
Files 357 357
Lines 29941 29941
=======================================
Hits 17632 17632
Misses 11329 11329
Partials 980 980 🚀 New features to boost your workflow:
|
vvoland
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
--platform=linuxor--platform=windowsis not commonly used (or recommended). Let's remove these from the list of suggested platforms.We should tweak this completion further, and sort the list based on the daemon's platform (putting linux first for a Linux daemon, and windows first on a Windows daemon), possibly with the correct architecture (and os-version) included, but we don't yet provide that information in
/_ping.- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)