Skip to content

Engdocs 3211#24261

Open
aevesdocker wants to merge 6 commits intodocker:mainfrom
aevesdocker:ENGDOCS-3211
Open

Engdocs 3211#24261
aevesdocker wants to merge 6 commits intodocker:mainfrom
aevesdocker:ENGDOCS-3211

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Mar 3, 2026

Description

Refreshes Desktop settings page as it was getting a bit out of hand. No new content, just made much more efficient and removed dead content (eg referring to old versions)

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Mar 3, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit cd7ccfd
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69a7f0d513572e000858479c
😎 Deploy Preview https://deploy-preview-24261--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Mar 3, 2026
@aevesdocker aevesdocker marked this pull request as ready for review March 4, 2026 08:35
Copy link
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟡 NEEDS ATTENTION

This is an excellent documentation refresh that successfully converts verbose bullet-point content into concise, scannable tables. The table-based format significantly improves readability and makes it easier to compare settings across platforms.

Issues Found

Medium Severity: Trailing Whitespace (5 instances)

Several table rows have trailing whitespace after the final | character. While these don't affect rendered output, they trigger git warnings and should be cleaned up.

Affected lines: 36, 38, 40, 45, 260 (and additional instances at lines 258, 259, 261, 262, 263, 278, 279)

Overall Assessment

The conversion strategy is sound and the content remains accurate. The removed image (shared-folder-on-demand.png) and associated Windows-specific section appear to be appropriate removals of outdated content. All links, front matter, and shortcode syntax are correct.

Once the trailing whitespace is cleaned up, this PR will be ready to merge.

For information on enforcing settings at an organization level, see [Settings Management](/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md).

## General

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content reorg looks great. Much easier to read and navigate different settings. One minor suggestion. Could we add a brief high-level description for each section? I think we can pretty much reuse what we had previously. For example - https://deploy-preview-24261--docsdocker.netlify.app/desktop/settings-and-maintenance/settings/#resources looks a bit incomplete without the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants