ipam: Support RequiresRequestReplay #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerouanton
reviewed
Aug 13, 2025
ipam/api.go
Outdated
Comment on lines
32
to
37
| RequiresMACAddress bool | ||
| RequiresRequestReplay bool |
Member
There was a problem hiding this comment.
These are currently documented as is (see here):
type Capability struct {
// Whether on address request, libnetwork must
// specify the endpoint MAC address
RequiresMACAddress bool
// Whether of daemon start, libnetwork must replay the pool
// request and the address request for current local networks
RequiresRequestReplay bool
}Would you mind duplicating these comments such that plugin developers know what they do?
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
olljanat
force-pushed
the
ipam-request-reply
branch
from
9e3c896 to
30c821f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature seems to be documented to libnetwork but missing from helper