Fix startup errors, add unit test for scheduled task errors (fixes L…

…emmyNet#5209)  (LemmyNet#5269)

* Fix startup errors, add ci check (fixes LemmyNet#5209)

* normal unit test

* cleanup

* shear

* remove serial

* migration

Cargo.toml

@@ -182,7 +182,6 @@ tracing = { workspace = true }
 tracing-actix-web = { workspace = true }
 tracing-subscriber = { workspace = true }
 url = { workspace = true }
-reqwest = { workspace = true }
 reqwest-middleware = { workspace = true }
 reqwest-tracing = { workspace = true }
 clokwerk = { workspace = true }

crates/db_schema/replaceable_schema/utils.sql

@@ -186,26 +186,26 @@ BEGIN
             AND pe.bot_account = FALSE
         UNION
         SELECT
-            pl.person_id,
+            pa.person_id,
             p.community_id
         FROM
-            post_like pl
-            INNER JOIN post p ON pl.post_id = p.id
-            INNER JOIN person pe ON pl.person_id = pe.id
+            post_actions pa
+            INNER JOIN post p ON pa.post_id = p.id
+            INNER JOIN person pe ON pa.person_id = pe.id
         WHERE
-            pl.published > ('now'::timestamp - i::interval)
+            pa.liked > ('now'::timestamp - i::interval)
             AND pe.bot_account = FALSE
         UNION
         SELECT
-            cl.person_id,
+            ca.person_id,
             p.community_id
         FROM
-            comment_like cl
-            INNER JOIN comment c ON cl.comment_id = c.id
+            comment_actions ca
+            INNER JOIN comment c ON ca.comment_id = c.id
             INNER JOIN post p ON c.post_id = p.id
-            INNER JOIN person pe ON cl.person_id = pe.id
+            INNER JOIN person pe ON ca.person_id = pe.id
         WHERE
-            cl.published > ('now'::timestamp - i::interval)
+            ca.liked > ('now'::timestamp - i::interval)
             AND pe.bot_account = FALSE) a
 GROUP BY
     community_id;
@@ -244,22 +244,22 @@ BEGIN
             AND pe.bot_account = FALSE
         UNION
         SELECT
-            pl.person_id
+            pa.person_id
         FROM
-            post_like pl
-            INNER JOIN person pe ON pl.person_id = pe.id
+            post_actions pa
+            INNER JOIN person pe ON pa.person_id = pe.id
         WHERE
-            pl.published > ('now'::timestamp - i::interval)
+            pa.liked > ('now'::timestamp - i::interval)
             AND pe.local = TRUE
             AND pe.bot_account = FALSE
         UNION
         SELECT
-            cl.person_id
+            ca.person_id
         FROM
-            comment_like cl
-            INNER JOIN person pe ON cl.person_id = pe.id
+            comment_actions ca
+            INNER JOIN person pe ON ca.person_id = pe.id
         WHERE
-            cl.published > ('now'::timestamp - i::interval)
+            ca.liked > ('now'::timestamp - i::interval)
             AND pe.local = TRUE
             AND pe.bot_account = FALSE) a;
     RETURN count_;

migrations/2024-12-20-090225_update-replaceable-schema/down.sql

@@ -0,0 +1,3 @@
+SELECT
+    1;
+

migrations/2024-12-20-090225_update-replaceable-schema/up.sql

@@ -0,0 +1,3 @@
+SELECT
+    1;
+

src/lib.rs

@@ -370,3 +370,18 @@ fn cors_config(settings: &Settings) -> Cors {
     _ => cors_default,
   }
 }
+
+#[cfg(test)]
+pub mod tests {
+  use activitypub_federation::config::Data;
+  use lemmy_api_common::context::LemmyContext;
+  use std::env::set_current_dir;
+
+  pub async fn test_context() -> Data<LemmyContext> {
+    // hack, necessary so that config file can be loaded from hardcoded, relative path.
+    // Ignore errors as this gets called once for every test (so changing dir again would fail).
+    set_current_dir("crates/utils").ok();
+
+    LemmyContext::init_test_context().await
+  }
+}