Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build commands are needed for AWS Amplify #1643

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cnpcshangbo
Copy link

@cnpcshangbo cnpcshangbo commented Oct 1, 2021

Summary

Based on tests from my end and AWS Amplify. The build commands are needed to show pages.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/HJV7Uwq1rQhJ7uKK26GHK2cNsRvu
✅ Preview: https://docsify-preview-git-fork-cnpcshangbo-patch-1-docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6b2371:

Sandbox Source
docsify-template Configuration

@sy-records sy-records changed the base branch from master to develop October 2, 2021 01:14
@sy-records
Copy link
Member

Does docsify need to be built even if it only uses index.html as an entry point?

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense for docsify to build dependencies when u import it as a single script.
Did u use the source code to set up your site instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants