fix EntityManager::create deprecations #2669

DubbleClick · 2023-08-17T13:57:05Z

No description provided.

mbabker · 2023-08-17T18:54:13Z

You'd need to bump the minimum ORM version to 2.13, as well. In 2.12 and earlier, the constructor is protected, so those versions have to use the (now deprecated) create() method.

DubbleClick · 2023-08-18T01:46:54Z

You'd need to bump the minimum ORM version to 2.13, as well. In 2.12 and earlier, the constructor is protected, so those versions have to use the (now deprecated) create() method.

Good catch, fixed.

doc/annotations.md

DubbleClick · 2023-08-19T02:40:22Z

I assume phpunit hiccuped for no particular reason as I see no correlation to the changes in the PR. Would you trigger workflows again @phansys ?

DubbleClick · 2023-08-19T09:04:30Z

Well, I have no idea what php 7.2's problem is.

franmomu

DriverManager::getConnection() receives an EventManager as third argument, I haven't checked why it only fails using the lowest dependencies.

franmomu · 2023-08-19T09:58:57Z

composer.json

@@ -56,7 +56,7 @@
        "doctrine/dbal": "^2.13.1 || ^3.2",
        "doctrine/doctrine-bundle": "^2.3",
        "doctrine/mongodb-odm": "^2.3",
-        "doctrine/orm": "^2.10.2",
+        "doctrine/orm": "^2.13.0",


I guess we should also change the conflict section to set this version since we are not testing < 2.13.0 anymore and that would require a changelog and release it as a minor 🤔

franmomu · 2023-08-19T10:20:53Z

DriverManager::getConnection() receives an EventManager as third argument, I haven't checked why it only fails using the lowest dependencies.

~~hmm probably it is not necessary to pass the eventmanager to the EntityManager~~

Update: see #2669 (comment)

franmomu · 2023-08-19T10:26:37Z

DriverManager::getConnection() receives an EventManager as third argument, I haven't checked why it only fails using the lowest dependencies.

apparently the third argument of the EntityManager constructor was added in 2.14, that's probably why it fails when installing the lowest dependencies.

~~I think we should move the EventManager argument to the DriverManager::getConnection() call and it should be fine (and do not pass it to EntityManager::__construct()).~~

Update: Connection::getEventManager() is deprecated, so I guess we should just bump to 2.14

DubbleClick · 2023-08-19T11:03:08Z

Bumped the minimum requirement and also added the conflict. I'd have never realised the third argument was only added in 2.14, thanks for looking into it.

codecov · 2023-08-19T16:10:44Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (4010c0c) 79.60% compared to head (cb30629) 79.60%.

❗ Current head cb30629 differs from pull request most recent head 87b614b. Consider uploading reports for the commit 87b614b to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2669   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files         161      161           
  Lines        8415     8415           
=======================================
  Hits         6699     6699           
  Misses       1716     1716

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

franmomu

@phansys should we defer this to next minor version? we are dropping support of doctrine/orm < 2.14 so I guess a changelog and a minor version is needed

phansys · 2023-08-19T18:19:34Z

@phansys should we defer this to next minor version? we are dropping support of doctrine/orm < 2.14 so I guess a changelog and a minor version is needed

Indeed.

phansys · 2023-09-08T09:38:07Z

CHANGELOG.md

@@ -18,6 +18,8 @@ a release.
 ---

 ## [Unreleased]
+### Removed
+- Support for `doctrine/orm` < 2.14


IMO, if we are not dropping support for a major version, we don't need an entry here.
On the other hand, if these changes are intended to fix deprecations, I think we should add an entry in the Fixed section explaining what deprecations are fixed.

👍 in this case these deprecations are only triggered in tests

phansys · 2023-09-08T09:46:17Z

composer.json

@@ -71,7 +71,7 @@
    "conflict": {
        "doctrine/dbal": "<2.13.1 || ^3.0 <3.2",
        "doctrine/mongodb-odm": "<2.3",
-        "doctrine/orm": "<2.10.2 || 2.16.0 || 2.16.1",
+        "doctrine/orm": "<2.14.0 || 2.16.0 || 2.16.1",


Suggested change

"doctrine/orm": "<2.14.0 || 2.16.0 || 2.16.1",

"doctrine/orm": "2.16.0 || 2.16.1",

~~Here we need at least 2.14 to use the EntityManager constructor.~~ I left the 2.10.2 version since it was there because #2272.

My bad, I didn't see that the "doctrine/orm": "^2.14.0" constraint is in the require-dev section.
I'm sorry, I think you can use your original approach.

So what's the plan here, keep the 2.14 in the require, but <2.10.2 in the conflict? Anything I can do?

I should've kept the original <2.14 conflict 😞, but let's solve it in #2639

franmomu · 2023-09-08T12:23:34Z

thanks @DubbleClick!

DubbleClick · 2023-09-08T12:24:12Z

You're most welcome :)

DubbleClick mentioned this pull request Aug 17, 2023

fix EventArgs::getEntityManger deprecation #2639

Merged

phansys reviewed Aug 18, 2023

View reviewed changes

doc/annotations.md Outdated Show resolved Hide resolved

franmomu reviewed Aug 19, 2023

View reviewed changes

franmomu approved these changes Aug 19, 2023

View reviewed changes

franmomu added the Needs Changelog note label Aug 19, 2023

fix EntityManager::create deprecations

87b614b

franmomu requested a review from phansys September 8, 2023 08:32

phansys reviewed Sep 8, 2023

View reviewed changes

phansys requested changes Sep 8, 2023

View reviewed changes

phansys approved these changes Sep 8, 2023

View reviewed changes

franmomu merged commit 512695c into doctrine-extensions:main Sep 8, 2023

DubbleClick deleted the em_create branch September 8, 2023 12:23

This was referenced Sep 8, 2023

feat: fix deprecation of creating EntityManager #2634

Closed

Add conflict with doctrine/orm <2.14 #2697

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix EntityManager::create deprecations #2669

fix EntityManager::create deprecations #2669

DubbleClick commented Aug 17, 2023

mbabker commented Aug 17, 2023

DubbleClick commented Aug 18, 2023

DubbleClick commented Aug 19, 2023

DubbleClick commented Aug 19, 2023

franmomu left a comment •

edited

Loading

franmomu Aug 19, 2023

franmomu commented Aug 19, 2023 •

edited

Loading

franmomu commented Aug 19, 2023 •

edited

Loading

DubbleClick commented Aug 19, 2023

codecov bot commented Aug 19, 2023 •

edited

Loading

franmomu left a comment

phansys commented Aug 19, 2023

phansys Sep 8, 2023 •

edited

Loading

franmomu Sep 8, 2023

phansys Sep 8, 2023

franmomu Sep 8, 2023 •

edited

Loading

phansys Sep 8, 2023

DubbleClick Sep 8, 2023

franmomu Sep 8, 2023

franmomu commented Sep 8, 2023

DubbleClick commented Sep 8, 2023

	"doctrine/orm": "<2.14.0 \|\| 2.16.0 \|\| 2.16.1",
	"doctrine/orm": "2.16.0 \|\| 2.16.1",

fix EntityManager::create deprecations #2669

fix EntityManager::create deprecations #2669

Conversation

DubbleClick commented Aug 17, 2023

mbabker commented Aug 17, 2023

DubbleClick commented Aug 18, 2023

DubbleClick commented Aug 19, 2023

DubbleClick commented Aug 19, 2023

franmomu left a comment • edited Loading

Choose a reason for hiding this comment

franmomu Aug 19, 2023

Choose a reason for hiding this comment

franmomu commented Aug 19, 2023 • edited Loading

franmomu commented Aug 19, 2023 • edited Loading

DubbleClick commented Aug 19, 2023

codecov bot commented Aug 19, 2023 • edited Loading

Codecov Report

franmomu left a comment

Choose a reason for hiding this comment

phansys commented Aug 19, 2023

phansys Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

franmomu Sep 8, 2023

Choose a reason for hiding this comment

phansys Sep 8, 2023

Choose a reason for hiding this comment

franmomu Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

phansys Sep 8, 2023

Choose a reason for hiding this comment

DubbleClick Sep 8, 2023

Choose a reason for hiding this comment

franmomu Sep 8, 2023

Choose a reason for hiding this comment

franmomu commented Sep 8, 2023

DubbleClick commented Sep 8, 2023

franmomu left a comment •

edited

Loading

franmomu commented Aug 19, 2023 •

edited

Loading

franmomu commented Aug 19, 2023 •

edited

Loading

codecov bot commented Aug 19, 2023 •

edited

Loading

phansys Sep 8, 2023 •

edited

Loading

franmomu Sep 8, 2023 •

edited

Loading