Refactor ORM QueryBuilder::setParameters() calls to use setParameter() instead due to a stricter type in 3.0
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) instead due to a stricter type in 3.0
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 79.68% 79.67% -0.01%
==========================================
Files 162 162
Lines 8455 8452 -3
==========================================
- Hits 6737 6734 -3
Misses 1718 1718
☔ View full report in Codecov by Sentry. |
franmomu
approved these changes
Oct 18, 2023
phansys
approved these changes
Oct 23, 2023
|
Thank you @mbabker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For B/C, the ORM's
QueryBuilder::setParameters()(plural) method has continued to accept a plain array throughout 2.x, but in 3.0 it is typehinted as anArrayCollection. So instead of having to pass a collection of Parameter objects, emulating the internals ofsetParameter()(singular), this just updates the code to call thesetParameter()method one-by-one (which shouldn't hurt any since these are only 2-item arrays).After #2639 it should be more feasible to see where some of the pain points lie, but for now, another piece of low-hanging fruit is knocked down.