Use real event for test #2718
Merged
Use real event for test #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2718 +/- ##
==========================================
+ Coverage 79.36% 79.39% +0.02%
==========================================
Files 162 162
Lines 8457 8454 -3
==========================================
Hits 6712 6712
+ Misses 1745 1742 -3 ☔ View full report in Codecov by Sentry. |
franmomu
commented
Oct 30, 2023
Comment on lines
-64
to
+55
| $eventAdapter->getObjectManager(); | ||
| $eventAdapter->getObject(); | ||
| $eventAdapter->setEventArgs($args); | ||
| static::assertSame($eventAdapter->getObjectManager(), $emMock); | ||
| static::assertInstanceOf(\stdClass::class, $eventAdapter->getObject()); |
There was a problem hiding this comment.
Since we are testing behavior, instead of expecting that the EventArgs::getObjectManager() and EventArgs::getObject() are called, we can check with the result of these calls.
phansys
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2639 (comment)