Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another batch of mapping tests refactored #2734

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Dec 8, 2023

Ref: #2708

Same logic as #2732 for this batch. Most of the changes in existing fixtures are meant to try and get them to have similar mapping definitions across mapping providers, which hopefully makes maintaining the tests simpler in the long run as one case is only needed for all 4 mapping configurations. Unfortunately, some quirks and differences in the mapping drivers themselves make this tricky in some places (and consolidating these mapping tests is starting to show that, like the loggable embeddable configs); those should be revisited at some point down the road.

The deleted files are all mapping test classes that are now merged into a single test class.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2ba8f94) 79.38% compared to head (957b197) 79.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Mapping/ExtensionMetadataFactory.php 70.58% 5 Missing ⚠️
src/Mapping/MappedEventSubscriber.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2734      +/-   ##
==========================================
- Coverage   79.38%   79.33%   -0.06%     
==========================================
  Files         162      162              
  Lines        8498     8506       +8     
==========================================
+ Hits         6746     6748       +2     
- Misses       1752     1758       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbabker mbabker force-pushed the mapping-test-refactor branch from e394fcf to 957b197 Compare December 8, 2023 20:33
@franmomu franmomu merged commit 598fead into doctrine-extensions:main Dec 13, 2023
16 of 18 checks passed
@franmomu
Copy link
Collaborator

thanks @mbabker!

@mbabker mbabker deleted the mapping-test-refactor branch December 13, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants