Another round of mapping refactoring in tests for cross-version compatibility #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2738 +/- ##
==========================================
- Coverage 79.33% 79.26% -0.07%
==========================================
Files 162 162
Lines 8506 8513 +7
==========================================
Hits 6748 6748
- Misses 1758 1765 +7 ☔ View full report in Codecov by Sentry. |
mbabker
force-pushed
the
metadata-test-refactoring
branch
from
283e24b to
07339d4
Compare
franmomu
approved these changes
Dec 15, 2023
|
thanks @mbabker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2708
We don't need to check for class presence on the ORM's attribute driver, we're well past the version that was introduced as a minimum requirement. Other than that, just some more fixture generation/synchronization and adjusting test setup to always use attributes on PHP 8 instead of hard requiring the annotation driver.