Add loaded entities profiler section #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
managed_entity_count
branch
from
1602c5e to
b4dd3e4
Compare
dmaicher
approved these changes
Feb 26, 2025
|
One observation: I have an app with 2 different databases and 2 entity managers. Should it maybe be split into different tables per entity manager instead as we do for the "Entities Mapping" tab? |
|
it should indeed be per entity manager |
mamazu
force-pushed
the
managed_entity_count
branch
from
b4dd3e4 to
28f5b33
Compare
mamazu
force-pushed
the
managed_entity_count
branch
from
28f5b33 to
83e4a8b
Compare
|
Rebased and split up between entity managers: |
dmaicher
reviewed
Feb 27, 2025
stof
reviewed
Feb 27, 2025
Co-authored-by: Christophe Coevoet <stof@notk.org> Co-authored-by: David Maicher <mail@dmaicher.de>
mamazu
force-pushed
the
managed_entity_count
branch
from
527f0b1 to
018423b
Compare
dmaicher
approved these changes
Feb 27, 2025
stof
approved these changes
Feb 27, 2025
SenseException
approved these changes
Mar 2, 2025
|
Should I also add a little text explaining that this only shows the amount of managed entities at the end of the program when the collector runs? |
|
No need I would say, that's how collector stats are usually collected. But I would welcome if there was as an assertion for this in ProfilerTest, that's our integration test for profiler. |
mamazu
force-pushed
the
managed_entity_count
branch
from
c384477 to
9b6a396
Compare
mamazu
force-pushed
the
managed_entity_count
branch
from
9b6a396 to
123bfcd
Compare
ostrolucky
changed the title
ostrolucky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Feature
Showing a list of entity classes and the amount of entities that are managed:
The reasoning
Doctrine has a nice lazy loading feature of entities however I don't think many people realize that this can create a huge object graph in the entity manager. As flushing will go in and check all the entities for updates.