Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against php 8.4 #506

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Test against php 8.4 #506

merged 1 commit into from
Oct 29, 2024

Conversation

sergiy-petrov
Copy link
Contributor

No description provided.

@greg0ire greg0ire added the CI label Oct 28, 2024
greg0ire
greg0ire approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK, but it prompts me to revisit #485 because I don't think we should add more and more PHP versions forever.

@greg0ire greg0ire added this to the 2.0.3 milestone Oct 29, 2024
@greg0ire greg0ire merged commit bb5c2b6 into doctrine:2.0.x Oct 29, 2024
13 checks passed
@greg0ire
Copy link
Member

Thanks @sergiy-petrov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiy-petrov @greg0ire @SenseException