Upgrade to PHPUnit 10

doctrine · Feb 18, 2024 · 27b89f5 · 27b89f5
1 parent a423a74
commit 27b89f5
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 15 deletions.
diff --git a/composer.json b/composer.json
@@ -41,7 +41,7 @@
         "doctrine/coding-standard": "^12",
         "phpstan/phpstan": "^1.8",
         "phpstan/phpstan-phpunit": "^1.0",
-        "phpunit/phpunit": "^9.5",
+        "phpunit/phpunit": "^10.0",
         "vimeo/psalm": "^5.11"
     },
     "autoload": {

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
-
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
      colors="true"
-     verbose="true"
      beStrictAboutOutputDuringTests="true"
      beStrictAboutTodoAnnotatedTests="true"
 >
@@ -13,9 +11,9 @@
         </testsuite>
     </testsuites>
 
-    <coverage>
+    <source>
         <include>
             <directory>./src/</directory>
         </include>
-    </coverage>
+    </source>
 </phpunit>
diff --git a/tests/AbstractLazyArrayCollectionTest.php b/tests/AbstractLazyArrayCollectionTest.php
@@ -14,7 +14,7 @@
  *
  * @covers \Doctrine\Common\Collections\AbstractLazyCollection
  */
-class AbstractLazyArrayCollectionTest extends BaseArrayCollectionTest
+class AbstractLazyArrayCollectionTest extends BaseArrayCollectionTestCase
 {
     /**
      * @param mixed[] $elements

diff --git a/tests/AbstractLazyCollectionTest.php b/tests/AbstractLazyCollectionTest.php
@@ -16,7 +16,7 @@
  *
  * @covers \Doctrine\Common\Collections\AbstractLazyCollection
  */
-class AbstractLazyCollectionTest extends BaseCollectionTest
+class AbstractLazyCollectionTest extends BaseCollectionTestCase
 {
     protected function setUp(): void
     {

diff --git a/tests/ArrayCollectionTest.php b/tests/ArrayCollectionTest.php
@@ -20,7 +20,7 @@
  *
  * @covers \Doctrine\Common\Collections\ArrayCollection
  */
-class ArrayCollectionTest extends BaseArrayCollectionTest
+class ArrayCollectionTest extends BaseArrayCollectionTestCase
 {
     /**
      * @param mixed[] $elements

diff --git a/tests/BaseArrayCollectionTest.php → tests/BaseArrayCollectionTestCase.php b/tests/BaseArrayCollectionTest.php → tests/BaseArrayCollectionTestCase.php
@@ -20,7 +20,7 @@
 use function next;
 use function reset;
 
-abstract class BaseArrayCollectionTest extends TestCase
+abstract class BaseArrayCollectionTestCase extends TestCase
 {
     /**
      * @param mixed[] $elements
@@ -183,7 +183,7 @@ public function testIterator(array $elements): void
     }
 
     /** @psalm-return array<string, array{mixed[]}> */
-    public function provideDifferentElements(): array
+    public static function provideDifferentElements(): array
     {
         return [
             'indexed'     => [[1, 2, 3, 4, 5]],
@@ -359,7 +359,7 @@ public function testMatchingWithSlicingPreserveKeys(array $array, array $slicedA
     }
 
     /** @return mixed[][] */
-    public function provideSlices(): array
+    public static function provideSlices(): array
     {
         return [
             'preserve numeric keys' => [

diff --git a/tests/BaseCollectionTest.php → tests/BaseCollectionTestCase.php b/tests/BaseCollectionTest.php → tests/BaseCollectionTestCase.php
@@ -16,7 +16,7 @@
 use function is_string;
 use function sprintf;
 
-abstract class BaseCollectionTest extends TestCase
+abstract class BaseCollectionTestCase extends TestCase
 {
     /** @var Collection<mixed> */
     protected Collection $collection;

diff --git a/tests/CollectionTest.php b/tests/CollectionTest.php
@@ -15,7 +15,7 @@
 use function count;
 use function is_string;
 
-class CollectionTest extends BaseCollectionTest
+class CollectionTest extends BaseCollectionTestCase
 {
     protected function setUp(): void
     {

diff --git a/tests/Expr/CompositeExpressionTest.php b/tests/Expr/CompositeExpressionTest.php
@@ -15,12 +15,26 @@
 class CompositeExpressionTest extends TestCase
 {
     /** @return list<array{type:string, expressions: list<mixed>}> */
-    public function invalidDataProvider(): array
+    public static function invalidDataProvider(): array
     {
         return [
             ['type' => CompositeExpression::TYPE_AND, 'expressions' => [new Value('value')]],
             ['type' => CompositeExpression::TYPE_AND, 'expressions' => ['wrong-type']],
-            ['type' => CompositeExpression::TYPE_NOT, 'expressions' => [$this->createMock(Expression::class), $this->createMock(Expression::class)]],
+            [
+                'type' => CompositeExpression::TYPE_NOT,
+                'expressions' => [
+                    new class () implements Expression {
+                        public function visit(ExpressionVisitor $visitor)
+                        {
+                        }
+                    },
+                    new class () implements Expression {
+                        public function visit(ExpressionVisitor $visitor)
+                        {
+                        }
+                    },
+                ],
+            ],
         ];
     }