Add missing types to the codebase #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Oct 14, 2024
| Comparison::GT => static fn ($object): bool => self::getObjectFieldValue($object, $field) > $value, | ||
| Comparison::GTE => static fn ($object): bool => self::getObjectFieldValue($object, $field) >= $value, | ||
| Comparison::IN => static function ($object) use ($field, $value): bool { | ||
| Comparison::EQ => static fn (object|array $object): bool => self::getObjectFieldValue($object, $field) === $value, |
There was a problem hiding this comment.
This test is the reason why I used array|object here and below:
collections/tests/ClosureExpressionVisitorTest.php
Lines 415 to 421 in 16dd296
| @@ -178,7 +178,7 @@ public function walkCompositeExpression(CompositeExpression $expr): Closure | |||
| /** @param callable[] $expressions */ | |||
| private function andExpressions(array $expressions): Closure | |||
| { | |||
| return static fn ($object): bool => array_all( | |||
| return static fn (object $object): bool => array_all( | |||
There was a problem hiding this comment.
I didn't use object|array here though. Running the ORM test suite with that type hint causes no issues.
SenseException
previously approved these changes
Oct 14, 2024
greg0ire
force-pushed
the
restore-types
branch
from
591b9bc
to
03d4e48
Compare
SenseException
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the types were wrongly reverted in f741a20, some others were never added.