Simplify handling of --all-or-nothing and --no-all-or-nothing options
#1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge up done, please address the conflicts |
|
@greg0ire I'll be away for the weekend, but I'll push the rebase around Monday. |
agustingomes
force-pushed
the
all-or-nothing-option
branch
from
da41dab to
d9764d0
Compare
|
@greg0ire rebased onto |
|
We ignore it, since breaking changes (here, removing a class) are OK during a major upgrade. |
greg0ire
previously approved these changes
Sep 2, 2024
greg0ire
reviewed
Sep 2, 2024
agustingomes
force-pushed
the
all-or-nothing-option
branch
from
d9764d0 to
51d59dd
Compare
|
@greg0ire I pushed a new entry in the |
greg0ire
approved these changes
Sep 2, 2024
SenseException
approved these changes
Sep 2, 2024
|
Thanks @agustingomes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allowing passing values to options for
--all-or-nothingoption is now removed, which allows the configuration of the negatable option--no-all-or-nothing, whihc in its turn allows to remove the added option in 3.8.1.The outcome is a much simpler logic to override the configuration of
all_or_nothingvia the CLI command.