Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output backslashes #1468

Merged
merged 2 commits into from
Nov 18, 2024
Merged

output backslashes #1468

merged 2 commits into from
Nov 18, 2024

Conversation

delboy1978uk
Copy link
Contributor

fixes #1467

@delboy1978uk
Copy link
Contributor Author

new output looks like this
image

@greg0ire
Copy link
Member

Please apply @stof 's comment from the issue

@delboy1978uk
Copy link
Contributor Author

@greg0ire I tried that, but it didn't work from a mac, possibly I misunderstood, but he asked me to quote the whole command with "? I did that and it forgot the $PATH and couldn't even find the command to run. Can someone on a Windows setup check this and suggest any necessary edits?

@greg0ire
Copy link
Member

greg0ire commented Nov 2, 2024

possibly I misunderstood

yes

but he asked me to quote the whole command with "

No he didn't, he asked you "[to use] double quotes in the command", not around it. So, something like --down "The\\Namespace"

@delboy1978uk
Copy link
Contributor Author

I'll have a look again tonight, thanks for the feedback

@delboy1978uk
alter output so escaped namespace works
f09f881 
update expected test output

fix cs checks

use " instead of '

amend test expectatioon to expect double quotes

add escape slashes again

fix expected testoutput
@delboy1978uk
Copy link
Contributor Author

Hi again @greg0ire :-D Apologies that I didn't get the chance to look at this again until now, but I have used quotes now and squashed my commits :-)
image

@greg0ire
Copy link
Member

Well there are 2 commits :P

@delboy1978uk
Copy link
Contributor Author

delboy1978uk commented Nov 18, 2024 •
edited
Loading

@greg0ire there are now, for some reason I had to apply a CS fix on a line of code that I didn't touch and that hadn't changed in years :-P

@greg0ire greg0ire added the Bug label Nov 18, 2024
@greg0ire greg0ire merged commit 3856beb into doctrine:3.8.x Nov 18, 2024
12 checks passed
@greg0ire greg0ire added this to the 3.8.3 milestone Nov 18, 2024
@greg0ire
Copy link
Member

Thanks @delboy1978uk !

@delboy1978uk
Copy link
Contributor Author

With pleasure, @greg0ire :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.8.3
Development

Successfully merging this pull request may close these issues.

escaped namespaces don't work in single quotes
2 participants
@delboy1978uk @greg0ire