Remove internal from Property accessor #12163
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @beberlei
In #11659 you introduce PropertyAccessor as a way to replace reflFields,
but the interface is internal.
Static analysis like PHPStan/Psalm does report internal class/methods because basically it means
And so we cannot rely on setValue/getValue.
Since we were able to use "freely" reflfields, I assume it should be the same for propertyAccessors.
As an exemple https://github.com/sonata-project/EntityAuditBundle use it a lot.