bump psalm, fix some issues on level 6 and improve type coverage

[orklah]

This PR does the following:

• bump psalm to last version
• fix some issues on level 6
• improve type coverage by adding types when needed

[VincentLanglet]

Can you also fix this: psalm/psalm-plugin-doctrine#84 (comment) ?

[VincentLanglet]

Suggested change

	* @var class-string
	* @var string
	* @psalm-var class-string

[orklah]

What's the rationale for this? PHPDocumentor and PHPStorm both understand this notation now. Is there another tool we want compatibility with that doesn't support this?

[VincentLanglet]

Someone with an older version of PHPStorm ? Someone with another IDE ?

[orklah]

@greg0ire WDYT? Should we keep class-string in @psalm annotations? What's the policy for doctrine repos?

[greg0ire]

For Doctrine repositories we use @psalm annotations historically, because of PHPStorm, but we might want to relax that, I hear that indeed PHPStorm understands these now. I'll ask about this internally, but I have no strong opinion since I'm not a PHPStorm user.

[orklah]

Thanks! Maybe that's something that could be enforced via CS rules, one way or another

[greg0ire]

After discussing this, we are not yet ready to enforce it, but we do think we should no longer require contributors to add prefixes.

[orklah]

Good to know, thanks!

I added the psalm prefix for now but I'll keep that in mind for next time :)

[greg0ire]

Yup, also, as pointed out internally by @ostrolucky, there are some tricky cases like cases involving template that should stay with prefixes.

[orklah]

yes. Also phpstorm doesn't yet read all annotations. Array shapes for example will be reported as an error, even more so with list (for example list<string, array{string, string}> will be a undefined class list)

[greg0ire]

Thanks @orklah !