This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Some changes - Bump base image version & more #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakaobr
commented
Oct 27, 2021
vakaobr
commented
- Adding helm chart
- Bumping version of base image to fix CVE's
- Adding whitelist for clair scan to some CVE's (not fixable by now)
- Change default exposed IP to be able to accept connections from a prometheus inside a k8s cluster
… whitelist for clair scan to some CVE's, change default exposed IP
sfairat15
reviewed
Jan 21, 2022
| @@ -7,13 +8,15 @@ RUN dotnet restore | |||
|
|
|||
| # Copy everything else and build | |||
| COPY ./src/* ./ | |||
| COPY ./src/queries/get_daily_or_monthly_costs.json ./queries/get_daily_or_monthly_costs.json | |||
| COPY ./src/queries/get_daily_or_monthly_costs.json ./custom_queries/get_daily_or_monthly_costs.json | |||
| COPY ./src/queries/azure_billing_by_resource_group.json ./custom_queries/azure_billing_by_resource_group.json | |||
There was a problem hiding this comment.
I think, you should not copy these files into Docker image
You should use ConfigMap/volumeMount at helm chart to bring these files to the app
sfairat15
reviewed
Jan 21, 2022
| WORKDIR /app | ||
| EXPOSE 80 | ||
| EXPOSE 8080 |
There was a problem hiding this comment.
could you explain, why 8080 port?
sfairat15
reviewed
Jan 21, 2022
| @@ -18,8 +18,8 @@ | |||
| "AzureBillingExporter": { | |||
| "commandName": "Project", | |||
| "launchBrowser": true, | |||
| "applicationUrl": "http://localhost:5000", | |||
| "launchUrl": "http://localhost:5000/metrics", | |||
| "applicationUrl": "http://0.0.0.0:5000", | |||
sfairat15
suggested changes
Jan 21, 2022
| @@ -0,0 +1,45 @@ | |||
| generalwhitelist: | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.