Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Danger: enable nested SwiftLint configurations by using lint_all_files option #13

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

dogo
Copy link
Owner

@dogo dogo commented Sep 22, 2024

Fixes issue #.
  • This pull request follows the coding standards
This PR changes:

This PR enables the use of nested SwiftLint configurations by setting the lint_all_files option in Danger SwiftLint. By default, Danger SwiftLint lints files individually, which disables nested configurations. With this change, it will lint all files at once, allowing nested configurations to work as expected, similar to running SwiftLint from the root folder.

Changes

  • Updated Danger SwiftLint configuration to use lint_all_files.

Why

  • Fixes the issue where nested .swiftlint.yml configurations were being ignored.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (d37428c) to head (9b556e9).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #13   +/-   ##
========================================
  Coverage    92.17%   92.17%           
========================================
  Files           37       37           
  Lines         1674     1674           
========================================
  Hits          1543     1543           
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dogo dogo force-pushed the feature/danger-swiftlint-nested-configs branch from 1eeed3c to 9b556e9 Compare September 22, 2024 14:51
@dogo dogo merged commit ad59103 into develop Sep 22, 2024
5 checks passed
@dogo dogo deleted the feature/danger-swiftlint-nested-configs branch September 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant