-
Notifications
You must be signed in to change notification settings - Fork 139
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
A new policy constraint to enforce p12 password quality.
The new *p12ExportPasswordConstraintImpl* constraint allows to check: * `password.minSize` - the minimum size for the password; * `password.minCharCategory` - a csv of minimum characters in each category, they are _capital_, _lower_, _digit_ and _punctuation_; * `password.substringMatch` - the size of substring sequence which cannot be repeated; * `password.maxRepeatedChar` - maximum number of repeating for each character; * `password.cracklibCheck` - a boolean to request an additional check with *cracklib* (it has to be installed if not present).
- Loading branch information
Showing
5 changed files
with
208 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172 changes: 172 additions & 0 deletions
172
base/ca/src/main/java/com/netscape/cms/profile/constraint/P12ExportPasswordConstraint.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| // --- BEGIN COPYRIGHT BLOCK --- | ||
| // This program is free software; you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation; version 2 of the License. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License along | ||
| // with this program; if not, write to the Free Software Foundation, Inc., | ||
| // 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| // | ||
| // (C) 2025 Red Hat, Inc. | ||
| // All rights reserved. | ||
| // --- END COPYRIGHT BLOCK --- | ||
| package com.netscape.cms.profile.constraint; | ||
|
|
||
| import java.io.BufferedReader; | ||
| import java.io.BufferedWriter; | ||
| import java.io.IOException; | ||
| import java.util.Locale; | ||
| import java.util.Map; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import org.mozilla.jss.netscape.security.x509.X509CertInfo; | ||
|
|
||
| import com.netscape.certsrv.profile.ERejectException; | ||
| import com.netscape.certsrv.property.EPropertyException; | ||
| import com.netscape.certsrv.property.IDescriptor; | ||
| import com.netscape.cms.profile.def.NoDefault; | ||
| import com.netscape.cms.profile.def.PolicyDefault; | ||
| import com.netscape.cmscore.apps.CMS; | ||
| import com.netscape.cmscore.request.Request; | ||
|
|
||
| /** | ||
| * This class ............. | ||
| * | ||
| * @author Marco Fargetta {@literal <mfargett@redhat.com>} | ||
| */ | ||
| public class P12ExportPasswordConstraint extends EnrollConstraint { | ||
|
|
||
| public static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(P12ExportPasswordConstraint.class); | ||
|
|
||
| public static final String CONFIG_PASSWORD_MIN_SIZE = "password.minSize"; | ||
| public static final String CONFIG_PASSWORD_MIN_CHAR_CATEGORY = "password.minCharCategory"; | ||
| public static final String CONFIG_PASSWORD_SUBSTRING_MATCH = "password.substringMatch"; | ||
| public static final String CONFIG_PASSWORD_MAX_REPEATED_CHAR = "password.maxRepeatedChar"; | ||
| public static final String CONFIG_PASSWORD_CRACKLIB_CHECK = "password.cracklibCheck"; | ||
|
|
||
| public P12ExportPasswordConstraint() { | ||
| super(); | ||
| addConfigName(CONFIG_PASSWORD_MIN_SIZE); | ||
| } | ||
|
|
||
| @Override | ||
| public void setConfig(String name, String value) | ||
| throws EPropertyException { | ||
| if (name.equals(CONFIG_PASSWORD_MIN_SIZE) || | ||
| name.equals(CONFIG_PASSWORD_SUBSTRING_MATCH) || | ||
| name.equals(CONFIG_PASSWORD_MAX_REPEATED_CHAR)) { | ||
| try { | ||
| Integer.parseInt(value); | ||
| } catch (Exception e) { | ||
| throw new EPropertyException(CMS.getUserMessage( | ||
| "CMS_INVALID_PROPERTY", name)); | ||
| } | ||
| } | ||
| super.setConfig(name, value); | ||
| } | ||
|
|
||
| @Override | ||
| public IDescriptor getConfigDescriptor(Locale locale, String name) { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void validate(Request req, X509CertInfo info) | ||
| throws ERejectException { | ||
| String method = "P12ExportPasswordConstraint: validate: "; | ||
| String password = req.getExtDataInString("serverSideKeygenP12Passwd"); | ||
| String param = getConfig(CONFIG_PASSWORD_MIN_SIZE); | ||
| if (!param.equals("") && password.length() < Integer.parseInt(param)) { | ||
| throw new ERejectException(CMS.getUserMessage(getLocale(req), | ||
| "CMS_PROFILE_P12EXPORT_PASSWORD_TOO_SHORT", param)); | ||
| } | ||
|
|
||
| param = getConfig(CONFIG_PASSWORD_MIN_CHAR_CATEGORY); | ||
| if (!param.equals("")) { | ||
| String[] catCharSize = param.split(","); | ||
| String passwordSubset = password.replaceAll("^\\p{Upper}*", "").replaceAll("\\d*+$", ""); | ||
| int[] catChars = {0, 0, 0, 0}; | ||
| if (!password.isEmpty()) { | ||
| catChars[0] = passwordSubset.split("(?<=\\p{Upper})", -6).length -1; | ||
| catChars[1] = passwordSubset.split("(?<=\\p{Lower})", -6).length -1; | ||
| catChars[2] = passwordSubset.split("(?<=\\d)", -6).length -1; | ||
| catChars[3] = passwordSubset.split("(?<=\\p{Punct})", -6).length -1; | ||
| } | ||
| for (int i = 0; i < 4; i++) { | ||
| if (catChars[i] < Integer.parseInt(catCharSize[i])) { | ||
| throw new ERejectException(CMS.getUserMessage(getLocale(req), | ||
| "CMS_PROFILE_P12EXPORT_PASSWORD_FEW_CHARS_CATEGORY", catCharSize)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| param = getConfig(CONFIG_PASSWORD_SUBSTRING_MATCH); | ||
| if (!param.equals("")) { | ||
| int seqSize = Integer.parseInt(param); | ||
| for (int i = 0; i< password.length() - (seqSize * 2); i++) { | ||
| String seq = password.substring(i, i + seqSize); | ||
| String invSeq = new StringBuilder(seq).reverse().toString(); | ||
| if(password.indexOf(seq, i + seqSize) > 0 || password.indexOf(invSeq, i + seqSize) > 0){ | ||
| throw new ERejectException(CMS.getUserMessage(getLocale(req), | ||
| "CMS_PROFILE_P12EXPORT_PASSWORD_SEQUENCE")); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| param = getConfig(CONFIG_PASSWORD_MAX_REPEATED_CHAR); | ||
| if (!param.equals("")) { | ||
| int maxRepeat = Integer.parseInt(param); | ||
| int mostRepeatedChar = password.chars().mapToObj(x -> (char) x) | ||
| .collect(Collectors.groupingBy(x -> x, Collectors.counting())) | ||
| .entrySet().stream().max(Map.Entry.comparingByValue()) | ||
| .get().getValue().intValue(); | ||
|
|
||
| if (maxRepeat < mostRepeatedChar) { | ||
| throw new ERejectException(CMS.getUserMessage(getLocale(req), | ||
| "CMS_PROFILE_P12EXPORT_PASSWORD_REPEATED_CHAR", param)); | ||
| } | ||
| } | ||
|
|
||
| if (getConfigBoolean(CONFIG_PASSWORD_CRACKLIB_CHECK)) { | ||
| try { | ||
| Process crack = new ProcessBuilder("/usr/sbin/cracklib-check").start(); | ||
| BufferedWriter crackIn = crack.outputWriter(); | ||
| BufferedReader crackOut = crack.inputReader(); | ||
| crackIn.write(password); | ||
| crackIn.close(); | ||
|
|
||
| String crackResult = crackOut.readLine().substring(password.length() + 2); | ||
| if (!crackResult.equals("OK")) { | ||
| throw new ERejectException(CMS.getUserMessage(getLocale(req), | ||
| "CMS_PROFILE_P12EXPORT_PASSWORD_CRACKLIB_FAILS", crackResult)); | ||
| } | ||
|
|
||
| } catch (IOException e) { | ||
| logger.error(method + "impossible check password with cracklib.", e); | ||
| } | ||
|
|
||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String getText(Locale locale) { | ||
| String[] params = { | ||
| getConfig(CONFIG_PASSWORD_MIN_SIZE, "-1"), | ||
| getConfig(CONFIG_PASSWORD_MIN_CHAR_CATEGORY, "-1"), | ||
| getConfig(CONFIG_PASSWORD_SUBSTRING_MATCH, "-1"), | ||
| getConfig(CONFIG_PASSWORD_MAX_REPEATED_CHAR, "-1"), | ||
| getConfig(CONFIG_PASSWORD_CRACKLIB_CHECK, "False") | ||
| }; | ||
| return CMS.getUserMessage(locale, "CMS_PROFILE_CONSTRAINT_P12EXPORT_PASSWORD_TEXT", params); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isApplicable(PolicyDefault def) { | ||
| return (def instanceof NoDefault); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters